Skip to content

Conversation

@PaulBouchier
Copy link
Collaborator

Set linear & angular speeds & accelerations to what they were in the humbe-based nav2 param file

@PaulBouchier
Copy link
Collaborator Author

You'll be glad to know that the jazzy branch of this repo works on both gazebo and hardware (tested with my minniebot robot).

I might have misinterpreted your comment about default parameters to be broader than you meant. Re-reading your comment, you highlighted some speeds that were different. I went back and checked the linear and angular speeds & accelerations in this PR's nav2 param files vs the humble-based nav2 param files, and found some discrepancies and rectified them to make them match the humble param file.

I feel it's working better than it was previously with these changes. It doesn't rotate so fast, and doesn't tend to overshoot on in-place rotation at the end of a move.

I am using linorobot2_hardware from @hippo5329 repo on the robot and micro-ros over wifi for this testing because I don't have a robot computer and the upstream linorobot2_hardware repo doesn't support micro-ros over wifi. I will both put a robot computer on the robot and test the upstream linorobot2_hardware against this jazzy branch, and also submit a PR to support micro-ros over wifi in the upstream repo.

@PaulBouchier
Copy link
Collaborator Author

I'm new to github workflows and to submitting PRs when my fork is 2nd in line, so I hope I did everything correctly. All the requested changes should be in place, and waiting for you to pull the trigger on the workflow.

@grassjelly
Copy link
Member

Thanks @PaulBouchier ! This LGTM. The build has also passed already. You can check it out here: https://github.com/linorobot/linorobot2/actions/runs/15512782548/job/43676864465?pr=159

Just posting the initial review here for reference:
#157 .

Let me run this one more time in sim and this should be approved anytime soon.

@grassjelly grassjelly merged commit 933ea3b into linorobot:jazzy Jun 8, 2025
2 checks passed
@PaulBouchier PaulBouchier deleted the jazzy-docker branch October 16, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants