feat: complete ARM64 support and add test case#34
Open
wkpark wants to merge 3 commits into
Open
Conversation
- Add AArch64 assembly template for probe generation - Update Makefile to detect architecture automatically via uname - Set EM_AARCH64 in ELF header for ARM64 systems - Add test-regmap to verify register mapping for arm64 and x86_64
7 tasks
- Correctly detect AArch64 NOP instructions (0xd503201f) in probeIsEnabled References: Commit shandowc@e0c98fc9 by Zhang Xiaodong <zhangxiaodong1@sensetime.com> Assisted-by: Gemini CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #29
Overview
This PR introduces full support for the ARM64 (AArch64) architecture
These changes were implemented and verified with the assistance of Gemini CLI.
Key Changes
ARM64 Support:
src/asm/libstapsdt-aarch64.s) for runtime probe generation.Makefileto automatically detect the architecture usinguname -m.EM_AARCH64on ARM64 systems.Code Quality & Testing:
tests/test-regmap.cto verify register mapping across different architectures.valgrindon an ARM64 environment to ensure zero memory leaks.Note
This contribution was developed in collaboration with Gemini CLI, ensuring adherence to the project's standards and providing comprehensive validation on real ARM64 hardware.
Test script with the pystapsdt
on arm64