Skip to content

ultraspan@hisovereign: Add Ultraspan applet#8407

Open
hisovereign wants to merge 3 commits intolinuxmint:masterfrom
hisovereign:add-ultraspan-final
Open

ultraspan@hisovereign: Add Ultraspan applet#8407
hisovereign wants to merge 3 commits intolinuxmint:masterfrom
hisovereign:add-ultraspan-final

Conversation

@hisovereign
Copy link

A panel applet that controls the Utlraspan wallpaper script: github.com/hisovereign/Ultraspan

-Can set wallpaper from panel
-set background modes
-start/stop random rotation

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.


Found 10 potential issue(s):

⚠️ sync_file_test

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:313

if (!GLib.file_test(RANDOM_FOLDER, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:478

if (GLib.file_test(lastImage, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:497

const isActive = GLib.file_test(randomFile, GLib.FileTest.EXISTS);

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:509

if (!GLib.file_test(RANDOM_FOLDER, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:535

if (!GLib.file_test(configPath, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:587

if (!GLib.file_test(SCRIPT_PATH, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:609

if (!GLib.file_test(folderPath, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:648

if (GLib.file_test(filePath, GLib.FileTest.EXISTS)) {

file_test() is a synchronous stat call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

⚠️ hardcoded_data_dir

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:32

Gettext.bindtextdomain(UUID, GLib.get_home_dir() + "/.local/share/locale");

Avoid hardcoding .local/share in paths. Use GLib.get_user_data_dir() instead,
which respects the XDG_DATA_HOME environment variable.

⚠️ hardcoded_config_dir

ultraspan@hisovereign/files/ultraspan@hisovereign/applet.js:41

const CONFIG_DIR = HOME + "/.config/ultraspan";

Avoid hardcoding .config in paths. Use GLib.get_user_config_dir() instead,
which respects the XDG_CONFIG_HOME environment variable.


Automated pattern check.

-addressed needed fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant