Stop using the bundled six that comes with Theano.#1539
Open
abergeron wants to merge 1 commit intolisa-lab:masterfrom
Open
Stop using the bundled six that comes with Theano.#1539abergeron wants to merge 1 commit intolisa-lab:masterfrom
abergeron wants to merge 1 commit intolisa-lab:masterfrom
Conversation
We want to remove the bundled copy in Theano so this makes pylearn2 compatible with that future change.
Member
|
.requirements.txt should also be updated, I think. No need to update the "requirements" part of the doc since "dependencies of Theano" are already mentioned. |
Member
|
I'm not sure this is good as told in the python 2 and 3 PR in Theano. On Tue, Jun 16, 2015 at 4:56 PM, Pascal Lamblin notifications@github.com
|
BluePAZ
approved these changes
Apr 20, 2018
BluePAZ
left a comment
BluePAZ
left a comment
There was a problem hiding this comment.
This is needed, and I had to change these files to get it to work with the latest Theano as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to remove the bundled copy in Theano so this makes pylearn2
compatible with that future change.