Skip to content

Conversation

@amtoaer
Copy link

@amtoaer amtoaer commented Feb 2, 2025

主要是修改写法,只有第四点会些许影响逻辑,但感觉原来忽略保存错误是 bug?(

  1. 解析响应部分修改为等价的连续索引
  2. 使用常规的 impl Default 实现默认值
  3. 构造 phrases 时使用 [].into_iter().enumerate() 代替 (1..=8).map(|id| match id { ... })
  4. let _ = store.save(); 修改为 store.save()?; 以正确进行错误传播

@liseami
Copy link
Owner

liseami commented Feb 3, 2025

收到,翻译那块代码大改了一波,我看下

@amtoaer
Copy link
Author

amtoaer commented Feb 3, 2025

看起来说的是 release 分支的变动,不然我改一下目标分支?

@amtoaer amtoaer changed the base branch from main to release February 3, 2025 03:03
@amtoaer
Copy link
Author

amtoaer commented Feb 3, 2025

已把目标分支修改为 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants