-
-
Notifications
You must be signed in to change notification settings - Fork 6
docs: usage query builder #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
it's weird @cofin i get test failures locally but not in ci, 1st time i see this 🤣 other than that the docs looks ok to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok im not crazy the ci wasnt testing the examples bypassing the pytest pyproject settings because of the tests being forced here.
this reveals interesting failures from this pr idk if they are legitimate or not as the builder api is still experimental you'll tell me
there is one other in configuration_10 that fails and rightly so i think we dont close the pool there
|
@cofin i fixed the failing tests i could, I dont get the failure on quickstart_4 (unrelated to this pr but test amples werent tested previously in ci) as it passes locally fine and lgtm |
b8cd8fc to
064db00
Compare
…uilder.rst - Each literalinclude now has a :caption: matching its section or subsection, wrapped in backticks - Improves clarity and navigation for code examples in the documentation - All Python examples are now referenced with contextual captions
064db00 to
687d0be
Compare
Description
Closes