Skip to content

Conversation

@euri10
Copy link
Collaborator

@euri10 euri10 commented Nov 17, 2025

@euri10
Copy link
Collaborator Author

euri10 commented Nov 17, 2025

it's weird @cofin i get test failures locally but not in ci, 1st time i see this 🤣

>           raise sqlspec.exceptions.SQLSpecError(msg)
E           sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, name], received [1, 2].

sqlspec/core/parameters/_alignment.py:229: SQLSpecError

 docs/examples/usage/usage_query_builder_9.py ⨯                                                                                                                                                          100% ██████████
=============================================================================================== short test summary info ================================================================================================
FAILED docs/examples/usage/usage_query_builder_10.py::test_example_10 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, email_1, email_2, name, name_1, name_2], received [1, 2, 3, 4, 5, 6].
FAILED docs/examples/usage/usage_query_builder_12.py::test_example_12 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [2, email], received [1, 2].
FAILED docs/examples/usage/usage_query_builder_13.py::test_example_13 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: 3 parameters provided but 4 placeholders detected.
FAILED docs/examples/usage/usage_query_builder_14.py::test_example_14 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [4, email, name, status], received [1, 2, 3, 4].
FAILED docs/examples/usage/usage_query_builder_17.py::test_example_17 - sqlspec.exceptions.SQLSpecError: SQLite database error: table users already exists
FAILED docs/examples/usage/usage_query_builder_19.py::test_example_19 - AttributeError: 'CreateIndex' object has no attribute 'table'
FAILED docs/examples/usage/usage_query_builder_22.py::test_example_22 - sqlspec.exceptions.SQLParsingError: SQLite SQL syntax error : near "SELECT": syntax error
FAILED docs/examples/usage/usage_query_builder_24.py::test_example_24 - ValueError: No result found, exactly one row expected
FAILED docs/examples/usage/usage_query_builder_31.py::test_example_31 - sqlspec.exceptions.SQLSpecError: SQLite database error: unrecognized token: "@"
FAILED docs/examples/usage/usage_query_builder_32.py::test_example_32 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: 3 parameters provided but 2 placeholders detected.
FAILED docs/examples/usage/usage_query_builder_9.py::test_example_9 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, name], received [1, 2].

Results (4.38s):
      69 passed
      11 failed
         - docs/examples/usage/usage_query_builder_10.py:6 test_example_10
         - docs/examples/usage/usage_query_builder_12.py:6 test_example_12
         - docs/examples/usage/usage_query_builder_13.py:6 test_example_13
         - docs/examples/usage/usage_query_builder_14.py:7 test_example_14
         - docs/examples/usage/usage_query_builder_17.py:6 test_example_17
         - docs/examples/usage/usage_query_builder_19.py:6 test_example_19
         - docs/examples/usage/usage_query_builder_22.py:6 test_example_22
         - docs/examples/usage/usage_query_builder_24.py:7 test_example_24
         - docs/examples/usage/usage_query_builder_31.py:6 test_example_31
         - docs/examples/usage/usage_query_builder_32.py:6 test_example_32
         - docs/examples/usage/usage_query_builder_9.py:6 test_example_9
  ~/PycharmProjects/sqlspec on   169_usage_query_builder ❯        

other than that the docs looks ok to me

@euri10 euri10 marked this pull request as ready for review November 17, 2025 19:56
@euri10 euri10 changed the title feat(docs): usage query builder docs: usage query builder Nov 18, 2025
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok im not crazy the ci wasnt testing the examples bypassing the pytest pyproject settings because of the tests being forced here.
this reveals interesting failures from this pr idk if they are legitimate or not as the builder api is still experimental you'll tell me
there is one other in configuration_10 that fails and rightly so i think we dont close the pool there

@euri10
Copy link
Collaborator Author

euri10 commented Nov 18, 2025

@cofin i fixed the failing tests i could, I dont get the failure on quickstart_4 (unrelated to this pr but test amples werent tested previously in ci) as it passes locally fine and lgtm
for the others related to the pr ie the query_builder one can you take a look please ?

@cofin cofin force-pushed the 169_usage_query_builder branch from b8cd8fc to 064db00 Compare November 18, 2025 14:56
…uilder.rst

- Each literalinclude now has a :caption: matching its section or subsection, wrapped in backticks
- Improves clarity and navigation for code examples in the documentation
- All Python examples are now referenced with contextual captions
@cofin cofin force-pushed the 169_usage_query_builder branch from 064db00 to 687d0be Compare November 18, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: test ./usage/query_builder.rst

2 participants