Conversation
|
why is preview so bad? idk. |
|
wrt uv migration this is ready |
| install: clean ## Install the project, dependencies, and pre-commit for local development | ||
| @if ! $(PDM) --version > /dev/null; then echo '=> Installing PDM'; $(MAKE) install-pdm; fi | ||
| @if ! $(uv) --version > /dev/null; then echo '=> Installing uv'; $(MAKE) install-uv; fi | ||
| @if [ "$(VENV_EXISTS)" ]; then echo "=> Removing existing virtual environment"; fi |
There was a problem hiding this comment.
i'm not sure what the rationale behind all the conditionality with venvs and tooling and whatever is, but i feel like it'd be overall easier if it...didn't exist? like to me the Makefile's only purpose is to define how the project-specific tooling ought to operate. If you're not using (uv in this case) the tooling, then you'd just not use the makefile?
The reason i bring it up here being there'd be no reason to have detroy/clean commands at all really.
There was a problem hiding this comment.
im not sure if this was from trying to support multiple things at once (pip, poetry) or not but it can die
There was a problem hiding this comment.
The reason i bring it up here being there'd be no reason to have detroy/clean commands at all really.
What's the workflow you are thinking here?
There was a problem hiding this comment.
just that you almost dont even need a make install. by default uv run pytest will sync ahead of time. so i'm just not sure what cleaning out the venv would actually do.
There was a problem hiding this comment.
I'm mostly coming from my very simple makefiles from e.g. cappa which are just ways to ensure the command i run locally is exactly what's getting run in CI.
that, and it's really easy to see the total set of linters/formatters being applied to the project. by comparison, i've found the makefile setup (and pre-commit in particular) to be a confusing impediment
| "pytest-cov", | ||
| ] | ||
|
|
||
| # TODO: needs migrating. Poe? |
There was a problem hiding this comment.
do these need to exist? each basically has a corresponding make command
There was a problem hiding this comment.
it can go away for now. i think the idea was to shuffle things into pyproject and lighten the Make targets
fix(docs): add versioning
|
Documentation preview will be available shortly at https://litestar-org.github.io/type-lens-docs-preview/43 |
3 participants
Description
uv