-
Couldn't load subscription status.
- Fork 773
litmus checker Image registry bug fix for edit and clone experiments #5206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
litmus checker Image registry bug fix for edit and clone experiments #5206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a centralized useImageRegistry hook to fix image registry data handling across the Chaos Studio components. The fix addresses an issue where image registry fallback logic was not properly implemented in edit and clone experiment workflows.
- Created a new
useImageRegistryhook that centralizes image registry data fetching with fallback values - Replaced direct GraphQL queries in components with the new hook
- Added the hook to dependency arrays in
useEffecthooks to ensure proper re-rendering
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chaoscenter/web/src/hooks/useImageRegistry.ts | New hook that centralizes image registry fetching with fallback logic |
| chaoscenter/web/src/hooks/index.ts | Exports the new useImageRegistry hook |
| chaoscenter/web/src/views/StudioOverview/StudioOverview.tsx | Replaces direct query with useImageRegistry hook |
| chaoscenter/web/src/controllers/ChaosStudioEdit/ChaosStudioEdit.tsx | Integrates useImageRegistry hook and updates dependency array |
| chaoscenter/web/src/controllers/ChaosStudioClone/ChaosStudioClone.tsx | Integrates useImageRegistry hook and updates dependency array |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
00a2be4 to
30ab02e
Compare
Introduced a new useImageRegistry hook to centralize image registry data fetching and fallback logic. Updated ChaosStudioClone, ChaosStudioEdit, and StudioOverview components to use this hook, replacing direct queries and improving code reuse.. Signed-off-by: Harshit Panchbhai <[email protected]>
30ab02e to
56177e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fixed circular dependency, by directly using appstore hook file Signed-off-by: Harshit Panchbhai <[email protected]>
|
Hi @PriteshKiri can we run frontend checks, as I have made fix for cyclic dependency error that occured in last build |
|
Sure @harshit12339 |
Proposed changes
Introduced a new useImageRegistry hook to centralize image registry data fetching and fallback logic. Updated ChaosStudioClone, ChaosStudioEdit, and StudioOverview components to use this hook, replacing direct queries and improving code reuse.
This PR will fix #5204
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: