Skip to content

Conversation

@UJESH2K
Copy link
Contributor

@UJESH2K UJESH2K commented Oct 22, 2025

Fixes #5232

Summary

Upgrades golang.org/x/oauth2 from v0.21.0 → v0.27.0 to patch CVE-2025-22868 (DoS vulnerability).

Validation

✅ go build ./...
✅ go test ./...
✅ govulncheck shows no oauth2 vulnerability

No authentication or token flow regressions observed.

module github.com/litmuschaos/litmus/chaoscenter/authentication

go 1.22.0
go 1.23.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update it to 1.24.0 along with other 2 more places -

  • Dockerfile
  • CI build workflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review
I'll update and push

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jonsy13
Thanks for the review! 🙌
I’ve updated the Go version to 1.24.0 in all three places — go.mod, Dockerfile, and the CI build workflow as suggested.
Kindly review the latest changes and let me know if there are any other updates required. 😊

@UJESH2K UJESH2K force-pushed the fix/oauth2-vulnerability branch 4 times, most recently from f7b0f17 to ccc4ccf Compare October 23, 2025 19:09
@UJESH2K
Copy link
Contributor Author

UJESH2K commented Oct 23, 2025

The Trivy scan is currently failing on this PR due to a vulnerability in github.com/golang-jwt/jwt (CVE-2025-30204).
✅ This issue has already been addressed in a separate PR: #5246
.
For this PR, we are focusing on the OAuth2 vulnerability fix, and the JWT update will be merged through the linked PR.

@UJESH2K UJESH2K force-pushed the fix/oauth2-vulnerability branch from 6f66aa3 to ff10a26 Compare October 23, 2025 21:51
@UJESH2K UJESH2K force-pushed the fix/oauth2-vulnerability branch from ff10a26 to af3ffcc Compare October 23, 2025 21:55
UJESH2K and others added 11 commits October 23, 2025 21:57
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
Signed-off-by: UJESH KUMAR YADAV <[email protected]>
@UJESH2K UJESH2K force-pushed the fix/oauth2-vulnerability branch from af3ffcc to a8c2cb1 Compare October 23, 2025 21:57
@Jonsy13
Copy link
Contributor

Jonsy13 commented Oct 24, 2025

Please update this branch with main & resolve conflicts

@UJESH2K
Copy link
Contributor Author

UJESH2K commented Oct 25, 2025

please review the PRs they are up to date now !

golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
golang.org/x/oauth2 v0.21.0 h1:tsimM75w1tF/uws5rbeHzIWxEqElMehnc+iW793zsZs=
golang.org/x/oauth2 v0.21.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
golang.org/x/oauth2 v0.27.0 h1:da9Vo7/tDv5RH/7nZDz1eMGS/q1Vv1N/7FCrBhI9I3M=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done from go.mod not from here directly.First update go.mod & then run go mod tidy. Please fix.

Signed-off-by: UJESH KUMAR YADAV <[email protected]>
@Jonsy13 Jonsy13 merged commit e91c06c into litmuschaos:master Oct 26, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest hacktoberfest-accepted Accepted for HacktoberFest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix vulnerability: CVE-2025-22868 in golang.org/x/oauth2 (DoS from malicious token parsing)

3 participants