Add support for safety_settings in google LLM constructor #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| gemini_tools: NotGivenOr[list[_LLMTool]] = NOT_GIVEN, | ||
| http_options: NotGivenOr[types.HttpOptions] = NOT_GIVEN, | ||
| seed: NotGivenOr[int] = NOT_GIVEN, | ||
| safety_settings: NotGivenOr[list[types.SafetySettingOrDict] | dict[str, str]] = NOT_GIVEN, |
Contributor
There was a problem hiding this comment.
I think it would be best to only accept SafetySettingOrDict types for this parameter. If you want to support accepting dict[str, str] then you would need to cast it to SafetySetting anyway to pass to GenerateContentConfig
Suggested change
| safety_settings: NotGivenOr[list[types.SafetySettingOrDict] | dict[str, str]] = NOT_GIVEN, | |
| safety_settings: NotGivenOr[list[types.SafetySettingOrDict]] = NOT_GIVEN, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature Request: #3732
Adding in a way to define safety restrictions on Google LLM via the constructor params
Changes
Take
safety_settingslist/dict and pass it on to the LLMStream via_extra_kwargs.Note: Also added doc line for missing doc on
seedparam