feat(minimax): comprehensive TTS updates and parameter rename #3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for speech-2.6-hd and speech-2.6-turbo models - Add fluent emotion (exclusive to speech-2.6-* models) - Add 10 new voice IDs (social media, voice agent, English, VAPI series) - Rename english_normalization to text_normalization (supports Chinese/English) - Update documentation to reflect Chinese and English support - Improve trace_id extraction from response headers and body - Enhance error handling with detailed logging BREAKING CHANGE: Renamed parameter english_normalization to text_normalization
|
minimax seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
longcw
reviewed
Nov 4, 2025
Contributor
longcw
left a comment
longcw
left a comment
There was a problem hiding this comment.
looks good to me! something nit:
livekit-plugins/livekit-plugins-minimax/livekit/plugins/minimax/tts.py
Outdated
Show resolved
Hide resolved
added 2 commits
November 4, 2025 19:00
- Move informational logs from INFO to DEBUG level - Remove Chinese comments and translate to English - Fix missing text_normalization in API request payload - Clean up verbose logging statements
longcw
approved these changes
Nov 4, 2025
| async def _run(self, output_emitter: tts.AudioEmitter) -> None: | ||
| # Initialize with temporary ID, will be updated from WebSocket messages | ||
| request_id = utils.shortuuid() | ||
| trace_id_holder = {"trace_id": request_id} |
Contributor
There was a problem hiding this comment.
use trace_id directly instead of creating a dict?
- Move informational logs from INFO to DEBUG level - Remove Chinese comments and translate to English - Fix missing text_normalization in API request payload - Clean up verbose logging statements
|
@zhenyujia23-crypto zhenyujia23-crypto Suggestion adding the language selector parameter so its no always set as language detection auto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed parameter english_normalization to text_normalization