fix(remote_signer): fix ticket value calculation for capability-constraint pricing#3859
Closed
eliteprox wants to merge 3 commits intoja/remote-signer-ticketsfrom
Closed
fix(remote_signer): fix ticket value calculation for capability-constraint pricing#3859eliteprox wants to merge 3 commits intoja/remote-signer-ticketsfrom
eliteprox wants to merge 3 commits intoja/remote-signer-ticketsfrom
Conversation
…nsure correct price is requested from orch - Update tests to reflect new ticket parameters and capabilities for lv2v transactions
… video payments - Updated the payment request structure to include price information directly. - Adjusted logic to derive capabilities and constraints based on provided price info. - Removed outdated tests related to LV2V capabilities and pricing. - Ensured proper handling of missing or zero price information in payment generation.
…date payment request structure - Eliminated modelID from SegmentInfoSender to streamline payment processing. - Updated payment request to utilize priceInfo from orchestrator for better pricing accuracy.
Collaborator
Author
|
Closing PR as it not needed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR updates the remote signer's ticket value calculation to use capability/model-specific pricing from the gateway, so that accurate price info can be provided to the signer.
The change removes the
Typefield in favor ofPriceInfo.Capabilityfor capability and setsmodel_idtoPriceInfo.Constraintwhich matches how orchestrators advertise pricing forlive-video-to-videoSpecific updates (required)
Removes the
Typefield in favor ofPriceInfo.Capabilityfor capability and setsmodel_idtoPriceInfo.Constraintwhich matches how orchestrators advertise pricing forlive-video-to-videoOrchestratorInfo(including matchingTicketParams) before requesting payments, and sends that alongside the selected PriceInfo to the signer.OrchestratorInfo/PriceInfo, no longer performs its ownGetOrchestratorInforefresh, and normalizes defaults for capability/constraint.RemotePaymentRequestto replace theTypefield withPriceInfowhich contains pricing for all capabilities.OrchestratorInfo.CapabilityandPriceInfo.Constraintare used for ticket valuation on lv2v requests, matching how orchestrators advertise pricing forlive-video-to-videoHow did you test each of these updates (required)
-pricePerPixeland-pricePerUnitflag along with this models config:Does this pull request close any open issues?
Fixes how remote signer calculates ticket value, by ensuring it uses the correct capability/constraint price
Removes unintended requirement that orchestrator have
-pricePerPixeland-pricePerPixelflags setChecklist:
makeruns successfully./test.shpass