BYOC: Longer byoc stream stop timeout#3861
Open
ad-astra-video wants to merge 2 commits intolivepeer:masterfrom
Open
BYOC: Longer byoc stream stop timeout#3861ad-astra-video wants to merge 2 commits intolivepeer:masterfrom
ad-astra-video wants to merge 2 commits intolivepeer:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3861 +/- ##
=============================================
Coverage 32.24436% 32.24436%
=============================================
Files 169 169
Lines 41201 41201
=============================================
Hits 13285 13285
Misses 26915 26915
Partials 1001 1001
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
eliteprox
approved these changes
Jan 26, 2026
Collaborator
eliteprox
left a comment
There was a problem hiding this comment.
LGTM as a quick solution. Extending the timeouts can cause to "stuck capacity", IIRC.
For the backlog, I'd recommend to send a control message with timeout and let the worker (pytrickle) cleanup frame_processor tasks async. Then, /stop can return immediately and the worker can signal to the gateway to close trickle channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Want to extend default timeout on stop requests to 60 seconds to allow for cleanup.
In my video data app I have a number of LLM calls that would like to be able to have some time to wrap up to get all data.
May want to consider making this configurable in the future but 60 seconds seems reasonable and can always go much faster than that.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass