feat: Add capability price selection and refresh logic in remote payment sender#3862
Closed
eliteprox wants to merge 13 commits intoja/remote-signer-ticketsfrom
Closed
feat: Add capability price selection and refresh logic in remote payment sender#3862eliteprox wants to merge 13 commits intoja/remote-signer-ticketsfrom
eliteprox wants to merge 13 commits intoja/remote-signer-ticketsfrom
Conversation
This reverts commit f059422.
…nder - Implemented `selectCapabilityPrice` function to choose the appropriate price based on capabilities. - Updated `RequestPayment` method to utilize refreshed orchestrator info and fallback to cached prices when necessary. - Added unit tests to verify the new functionality for capability price usage and fallback behavior.
eliteprox
changed the title
… info retrieval - Removed direct calls to getOrchInfo in favor of a new refreshSession method. - Updated unit tests to mock refreshSession behavior for improved test coverage. - Ensured that orchestrator info is correctly handled during payment requests.
j0sh
force-pushed
the
ja/remote-signer-tickets
branch
from
bb04b97 to
4a5c0c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds price selection to the GetOrchestratorInfo requests sent by the
RemotePaymentSenderwithin the gateway node. This ensures that offchain go-livepeer gateways can utilize remote signer nodes to request jobs for the live-video-to-video pipeline.RemotePaymentSenderis used exclusively by offchain gateways.selectCapabilityPricefunction to choose the appropriate price based on capabilities.RequestPaymentmethod to utilize refreshed orchestrator info and fallback to cached prices when necessary.What does this pull request do? Explain your changes. (required)
Fixes capability/constraint pricing for remote signer configured gateways to ensure that are able to request jobs from orchestrators using the correct price.
Specific updates (required)
RemotePaymentSenderto userefreshSessionto get latest pricing when initializing a new streamselectCapabilityPricetolive_payment.gofor matching the requested capability/constraint to the orchestrator's advertised pipelines to return the correct price.How did you test each of these updates (required)
Tested with remote signer node and offchain gateway using the
live-video-to-video/nooppipeline which is the default fro whip ingest.Does this pull request close any open issues?
Fixes issue with gateways configured to use a remote signer being unable to start streams for
live-video-to-videopipelines due to "Insufficient Capacity" errorChecklist:
makeruns successfully./test.shpass