Skip to content

Fix crash in broadcaster max price calculation. #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j0sh merged 1 commit into from
Jan 30, 2026
+11 −0
Merged

Fix crash in broadcaster max price calculation. #3864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/broadcast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ func (cfg *BroadcastConfig) GetCapabilitiesMaxPrice(caps common.CapabilityCompar
return cfg.MaxPrice()
}
netCaps := caps.ToNetCapabilities()
if netCaps == nil || netCaps.Constraints == nil {
return cfg.MaxPrice()
}
price := big.NewRat(0, 1)
for capabilityInt, constraints := range netCaps.Constraints.PerCapability {
for modelID := range constraints.Models {
Expand Down
8 changes: 8 additions & 0 deletions server/broadcast_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,6 +1895,14 @@ func TestGetCapabilitiesMaxPrice(t *testing.T) {
cfg.SetMaxPrice(price)
assert.Equal(t, big.NewRat(10, 1), cfg.GetCapabilitiesMaxPrice(nil))

// Should return the max price if net capabilities are nil.
capabilitiesNilNet := &StubCapabilityComparator{NetCaps: nil}
assert.Equal(t, big.NewRat(10, 1), cfg.GetCapabilitiesMaxPrice(capabilitiesNilNet))

// Should return the max price if constraints are nil.
capabilitiesNilConstraints := &StubCapabilityComparator{NetCaps: &net.Capabilities{}}
assert.Equal(t, big.NewRat(10, 1), cfg.GetCapabilitiesMaxPrice(capabilitiesNilConstraints))

// Create capabilities object.
capability1 := core.Capability(1)
modelID1 := "model1"
Expand Down
Loading