Skip to content

BYOC: add orch swap reporting same as lv2v#3865

Merged
ad-astra-video merged 2 commits intolivepeer:masterfrom
ad-astra-video:add-byoc-orch-swap-event
Jan 30, 2026
Merged

BYOC: add orch swap reporting same as lv2v#3865
ad-astra-video merged 2 commits intolivepeer:masterfrom
ad-astra-video:add-byoc-orch-swap-event

Conversation

@ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Removes generic error reporting in favor of more specific stream_trace event similar to how lv2v pipeline reports orchestrator swaps.

lv2v orchestrator swap event reporting

monitor.SendQueueEventAsync("stream_trace", map[string]interface{}{
"type": "orchestrator_swap",
"stream_id": params.liveParams.streamID,
"request_id": params.liveParams.requestID,
"pipeline": params.liveParams.pipeline,
"pipeline_id": params.liveParams.pipelineID,
"message": err.Error(),
"orchestrator_info": map[string]interface{}{
"address": params.liveParams.sess.Address(),
"url": params.liveParams.sess.Transcoder(),
},
})

Specific updates (required)

  • remove sendErrorEvent generic error reporting
  • replace with stream trace event orchestrator_swap type

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the go Pull requests that update Go code label Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.22090%. Comparing base (a38b81a) to head (4621911).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3865         +/-   ##
===================================================
+ Coverage   32.15928%   32.22090%   +0.06162%     
===================================================
  Files            170         170                 
  Lines          41310       41321         +11     
===================================================
+ Hits           13285       13314         +29     
+ Misses         27023       27005         -18     
  Partials        1002        1002                 
Files with missing lines Coverage Δ
byoc/stream_gateway.go 58.30986% <100.00000%> (+0.65607%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38b81a...4621911. Read the comment docs.

Files with missing lines Coverage Δ
byoc/stream_gateway.go 58.30986% <100.00000%> (+0.65607%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ad-astra-video ad-astra-video merged commit 778c2e1 into livepeer:master Jan 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants