Draft
Conversation
d63d90f to
8b60101
Compare
This requires threading through an additional field for each of the discovery types to pass into the OrchestratorInfo request. The behavior for non-discovery gateways should remain the same.
This reverts commit 555ab44.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3866 +/- ##
===================================================
+ Coverage 32.47906% 32.66951% +0.19045%
===================================================
Files 170 171 +1
Lines 41673 41929 +256
===================================================
+ Hits 13535 13698 +163
- Misses 27113 27199 +86
- Partials 1025 1032 +7
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional remote discovery feature to the remote signer node. Client using the remote signer can now discover orchestrators and their supported capabilities on the network.
Usage
Remote signer node gets a
-remoteDiscoveryflag. This is only usable in remote signer mode for now and is opt-in. All the other gateway-side orchestrator configuration flags are supported here:-orchWebhookUrl,-orchAddr,-orchBlocklist,-extraNodesetc.If the gateway is using a remote signer (via
-remoteSignerUrl) and has no other orchestrator sources (eg, webhook, orchestrator list) then it will fall back to using the remote signer's discovery endpoint.The discovery endpoint is
GET /discover-orchestrators. It returns a JSON list of [{"address":...,"capabilities":[...]}] where the address is the URI the orchestrator can be reached at, and thecapabilitiesis a list of capabilities the orchestrator supports, eglive-video-to-video/streamdiffusion. There is also an optionalcapsquery parameter to return only the subset of orchestrators matching the capability (exact string match). Multiplecapsparameters can be included (OR).Remote Discovery Implementation
Supporting Changes
DB Discovery pool and Webhook Discovery pool are updated to use a "builder pattern" of config structs + initializer, matching the regular orchestrator pool. The existing constructor interfaces are left untouched, but the plumbing underneath uses the new builder pattern. This is so we can support two things: the IgnoreCapacityCheck and the [TODO: DB Discovery refresh]
Remote discovery uses the GetOrchestrators() code instead of re-implementing half of what it does. However, to avoid returning capacity errors during the call (it is capabilities we want), we need to thread through the
IgnoreCapacityCheckflag a couple places from the webhook, DB discovery, etc.Tests, docs, etc.