Conversation
…g logic - Introduced Capability_BYOCExternal constant to represent the new BYOC external capability. - Updated CapabilityNameLookup to include a name for BYOC external capability. - Enhanced GetCapabilitiesPrices method in orchestrator to append pricing for BYOC external capabilities, ensuring seamless integration with existing pricing logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
===================================================
+ Coverage 32.47906% 32.51619% +0.03713%
===================================================
Files 170 170
Lines 41673 41690 +17
===================================================
+ Hits 13535 13556 +21
+ Misses 27113 27111 -2
+ Partials 1025 1023 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- Introduced multiple test cases for BYOC external capabilities, including validation of pricing logic and edge cases. - Implemented tests to ensure correct pricing retrieval for both default and sender-specific scenarios. - Added checks for handling zero and negative prices, as well as cases with nil external capabilities.
j0sh
approved these changes
Feb 11, 2026
Collaborator
|
🚢 🇮🇹 |
- Renamed Capability_BYOCExternal to Capability_BYOC for consistency. - Updated CapabilityNameLookup and related tests to reflect the new naming. - Adjusted orchestrator pricing logic to use the updated capability constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Merges BYOC external capability pricing into the existing
OrchestratorInfo.CapabilitiesPricesresponse, making BYOC capabilities discoverable through the same gRPC channel used for built-in capabilities like Live Video to Video. This eliminates the need for clients to call a separate HTTP endpoint to discover which BYOC capabilities an orchestrator offers and at what price.A new
Capability_BYOC(37) enum value is used as the capability ID, with the registered BYOC capability name (e.g., "comfystream") placed in thePriceInfo.Constraintfield — the same pattern used by LV2V models (capability 35 + constraint = model_id).Specific updates (required)
Capability_BYOC = 37to the capability enum incore/capabilities.goand registered"byoc"inCapabilityNameLookupGetCapabilitiesPricesincore/orchestrator.goto iterate over registered external capabilities (ExternalCapabilities.Capabilities) and append aPriceInfoentry for each, usingCapability_BYOCas the capability ID and the capability name as the constraint"default"price, and skips capabilities with no valid priceHow did you test each of these updates (required)
capabilities_pricesentries with capability 37 to discover BYOC capabilities and construct payment tickets using the same_select_price_infopath as LV2VDoes this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass