add duration check for input files#434
Merged
ad-astra-video merged 8 commits intolivepeer:masterfrom May 29, 2025
Merged
Conversation
j0sh
approved these changes
May 27, 2025
Collaborator
j0sh
left a comment
j0sh
left a comment
There was a problem hiding this comment.
lgtm with a unit test. It would also be nice to have a case where we have a long video that does not trigger this check (eg, input via pipe) but do you have an idea of how heavy of a test that would be?
Contributor
Author
|
@j0sh I added two tests. One tests good and bad segments using file inputs. Second test uses a pipe input with 301 second input that does not trigger an error. |
j0sh
reviewed
May 28, 2025
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Co-authored-by: Josh Allmann <joshua.allmann@gmail.com>
Collaborator
|
Simplified the tests in 93a85e7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to test input segments for durations longer than 5 minutes.
Fixes bug that created ridiculously large output segments.
long-ts.log
wrong-ts.log
cc @rickstaa