Skip to content

feat: Implement keyword search and delete_chunk at ChromaDB #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Implement keyword search and delete_chunk at ChromaDB #3057

wants to merge 10 commits into from

Conversation

bwook00
Copy link

@bwook00 bwook00 commented Aug 7, 2025 •
edited
Loading

What does this PR do?

Keyword Search

keyword search is based on chroma cookbook

Delete Chunk

I added delete chunk function

Hybrid Search

Hybrid Search is not yet officially supported by Chroma chroma issue

This issue is related #3008 but I don't know this is end of issue
So, If I have to do something more, feel free to comment!

close #3008

Test Plan

I add test code and run by below command

pytest tests/unit/providers/vector_io/remote/test_chroma.py -v -s --tb=long --disable-warnings --asyncio-mode=auto

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 7, 2025
@bwook00 bwook00 changed the title Implement keyword search and delete_chunk at ChromaDB feat: Implement keyword search and delete_chunk at ChromaDB Aug 7, 2025
@bwook00
Copy link
Author

bwook00 commented Aug 12, 2025

@franciscojavierarceo If you have time, Can you review my PR? 😀

@r3v5
Copy link
Contributor

r3v5 commented Aug 15, 2025 •
edited
Loading

Thanks for your PR! Could you please implement hybrid search for Chroma DB too?

I have introduced Reranker class for that in #3064. This PR will be merged soon hence you will be able to use generic reranker infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@leseb leseb Awaiting requested review from leseb leseb is a code owner

@bbrowning bbrowning Awaiting requested review from bbrowning bbrowning is a code owner

@reluctantfuturist reluctantfuturist Awaiting requested review from reluctantfuturist reluctantfuturist is a code owner

@mattf mattf Awaiting requested review from mattf mattf is a code owner

@slekkala1 slekkala1 Awaiting requested review from slekkala1 slekkala1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement v1/vector_stores/{vector_store_id}/search for Chroma
2 participants
@bwook00 @r3v5