-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: turn OpenAIMixin into a pydantic.BaseModel #3671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c465472
fd06717
a765f1c
6fa23d8
d158596
733e72c
8658949
96232e2
7fe3dac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -22,7 +22,7 @@ class CerebrasImplConfig(RemoteInferenceProviderConfig): | |||||
description="Base URL for the Cerebras API", | ||||||
) | ||||||
api_key: SecretStr = Field( | ||||||
default=SecretStr(os.environ.get("CEREBRAS_API_KEY")), | ||||||
default=SecretStr(os.environ.get("CEREBRAS_API_KEY")), # type: ignore[arg-type] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
And mypy will be happy There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i removed the blanket excludes. i want to avoid rolling more things into this PR. |
||||||
description="Cerebras API Key", | ||||||
) | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,12 @@ | |
|
||
@json_schema_type | ||
class DatabricksImplConfig(RemoteInferenceProviderConfig): | ||
url: str = Field( | ||
url: str | None = Field( | ||
default=None, | ||
description="The URL for the Databricks model serving endpoint", | ||
) | ||
api_token: SecretStr = Field( | ||
default=SecretStr(None), | ||
default=SecretStr(None), # type: ignore[arg-type] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i hope to handle this later. i removed the blanket exclude so we can see the specific instances. |
||
description="The Databricks API token", | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove litellm from RemoteProviderSpec in the registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done