-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Enhance ResponseGuardrailSpec with additional fields #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added fields for guardrail configuration including description, enabled, severity, action, policy_id, version, categories, thresholds, max_violations, config, tags, and metadata.
|
Hi @natedemoss! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
cdoern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question to get started
| Fields | ||
| ------ | ||
| type: Identifier for the guardrail implementation (e.g. 'llama-guard', 'content-filter'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these look great, but can I ask where these are coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the “type” values come from the backend guardrail config, not from agents.py. They’re IDs the server maps to concrete handlers (e.g., llama-guard, content-filter). Resolution happens during create_openai_response on the backend. If helpful, I can add a doc note in ResponseGuardrailSpec pointing to the registry module or config path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I can make a new PR with a comment with less specificality.
What does this PR do?
Adds a production-oriented
ResponseGuardrailSpecmodel tosrc/llama_stack_api/agents.pyenabling structured guardrail configuration during response generation. Supports both string guardrail IDs and inline specs via the unionResponseGuardrail = str | ResponseGuardrailSpec. Fields include:type, description, enabled, severity, action, policy_id, version, categories, thresholds, max_violations, config, tags, metadata. Enforces strict schema (extra='forbid') and provides anormalized()helper for category cleanup.Test Plan
Default construction
Extra key rejection
Category normalization
Union usage in API (integration)
OpenAPI/spec regeneration
Negative thresholds (optional future test if validation added)
All tests pass locally (manual execution). Add automated unit test file in follow-up PR if not already present.
-- Nate DeMoss