add opentelemetry tracing instrumentation #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
tracing
branch
2 times, most recently
from
e34a83d to
cfc828e
Compare
sallyom
force-pushed
the
tracing
branch
5 times, most recently
from
0b1c9a6 to
898b30e
Compare
The connector variable is a *string from flag.String(), but the logger was printing the pointer address instead of the actual string value. This fixes the log output to show 'connector=nixlv2' instead of 'connector=0xc00012a1e0'.
Signed-off-by: sallyom <[email protected]>
Contributor
|
@sallyom the routing-sidecar code has been moved to inference-scheduler repo (see this repo's README). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.