refactor/remove-old-monitor-code #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doutriaux1
approved these changes
Dec 2, 2025
Collaborator
doutriaux1
left a comment
doutriaux1
left a comment
There was a problem hiding this comment.
Completely removed? You don't want to leave something in to say "deprecated"?
bgunnar5
changed the title
Member
Author
|
@doutriaux1 This will be going into Merlin v2.0 so I think it's safe to completely remove it. |
Collaborator
@bgunnar5 ok then it's fine. Are you putting a warning in develop then? |
Member
Author
|
@doutriaux1 I can. The only thing that's really changing here is the backend functionality and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old v1.0 Monitor code that's no longer used. Really this is just trying to clean up the codebase a bit.