Skip to content

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Nov 8, 2022

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from lloydwoodham November 8, 2022 09:15
@height
Copy link

height bot commented Nov 8, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Comment on lines 27 to 28
ax.plot(times, dens_data.y)
plt.show()
pass No newline at end of file
plt.show() No newline at end of file
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 28-29 refactored with the following changes:

Comment on lines -27 to +29
ax[0].set(
title=f'PSP SWP SPI data from {load_date.date()}',
ylabel=f'$cm^{3}$'
)
ax[1].set(
ylabel=f'km/s'
)
ax[-1].set(
xlabel='Time',
ylabel=f'km/s'
)
ax[0].set(title=f'PSP SWP SPI data from {load_date.date()}', ylabel='$cm^3$')
ax[1].set(ylabel='km/s')
ax[-1].set(xlabel='Time', ylabel='km/s')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 27-37 refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Nov 8, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.30%.

Quality metrics Before After Change
Complexity 0.68 ⭐ 0.70 ⭐ 0.02 👎
Method Length 198.50 😞 195.00 😞 -3.50 👍
Working memory 10.36 😞 10.41 😞 0.05 👎
Quality 56.95% 🙂 56.65% 🙂 -0.30% 👎
Other metrics Before After Change
Lines 69 60 -9
Changed files Quality Before Quality After Quality Change
mikes_psp_tutorial.py 70.38% 🙂 70.52% 🙂 0.14% 👍
mikes_psp_tutorial_cdflib.py 50.59% 🙂 50.81% 🙂 0.22% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants