Feature/open-meteo - #146
Open
j-era wants to merge 7 commits into
Open
Conversation
added 7 commits
January 12, 2025 17:59
# Conflicts: # platformio/include/config.h # platformio/platformio.ini # platformio/src/api_response.cpp # platformio/src/config.cpp # platformio/src/display_utils.cpp # platformio/src/main.cpp # platformio/src/renderer.cpp
Contributor
|
I like this idea and will try them locally. It would be helpful if this PR didn't have so many gratuitous formating changes, it makes the actual changes harder to find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lmarzen I really appreciate your work. Great!
What do you thing about supporting https://open-meteo.com/
I have implemented a first version. Can you see if it works for you? Unfortunately I don't have a firebeetle and also no api access to open weather map.
(PS: I have moved sensitive data to an ignored credentials.h, see credentials.h.template)