Repository navigation
Make --changed-only plural rescue format-aware - #104
Merged
Merged
Conversation
The plural branch in filterMissing stripped only gettext's `__plural_N`, so for a YAML/JSON group (`milestone_count.few`) the strip was a no-op and the branch was dead. #636's synthesis produced the categories the locale needs and --changed-only then dropped them. - New group in a PR: one/other survived, few/many were dropped — a wrong file that looks like success. - Reworded source: synthesis yields only few/many (one/other already satisfied), both were dropped, and translate printed "No changed keys need translation". A silent no-op with no artifact. Both sites fixed by reusing the importer's group rule (>=2 sibling CLDR categories, nothing nested) over the changed keys of the same file, so a lone dotted `errors.other` is still not treated as a plural group: - git-changes.ts filterMissing (translate/ci --changed-only) - pull.ts filterUpdatesByKeys, which discarded correct few/many the backend returned Tests compose synthesis with filterByGitChanges against a real git repo, the seam neither side covered: the #636 tests assert on synthesis output before filtering, and no git-changes test mentioned few or many.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plural branch in filterMissing stripped only gettext's
__plural_N, so for a YAML/JSON group (milestone_count.few) the strip was a no-op and the branch was dead. #636's synthesis produced the categories the locale needs and --changed-only then dropped them.Both sites fixed by reusing the importer's group rule (>=2 sibling CLDR categories, nothing nested) over the changed keys of the same file, so a lone dotted
errors.otheris still not treated as a plural group:Tests compose synthesis with filterByGitChanges against a real git repo, the seam neither side covered: the #636 tests assert on synthesis output before filtering, and no git-changes test mentioned few or many.