Repository navigation
Point check at Localhero when translations are missing - #105
Merged
Merged
Conversation
- Plain-text report without a localhero.json ends with one line linking to localhero.ai - Shares the step summary's wording via FILL_MISSING_POINTER - Leaves --json, --format github and configured projects unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npx @localheroai/cli checkon a repo without alocalhero.jsonprinted its whole report without ever mentioning Localhero. On a real Rails repo that is 315 lines ending in a list of hints, with no next step. The "can fill missing translations" line only existed in the GitHub step summary, which only configured projects see.The plain-text report now ends with the same line when translations are missing:
localhero.jsonand only when at least one locale has missing or empty values.--json,--format githubor the changed-only report, nor for configured projects.FILL_MISSING_POINTER, so the two cannot drift.Verified
--format githubdoes not print it,--jsonstays valid JSON, and a configured rig does not print it.