Repository navigation
Keep Jest out of local agent worktrees - #111
Merged
Merged
Conversation
- Agent worktrees under .claude/ hold old copies of the tests, which ran alongside the real suite (231 suites instead of 84) and could fail a release check - testPathIgnorePatterns replaces Jest's default, so /node_modules/ is listed too
arvida
added a commit
that referenced
this pull request
Oct 8, 2026
* Stand down when a sync belongs to another app in the repo - Send the config's projectId when fetching a sync; the server answers with project_matches (localheroai/localhero-ai#841) - On a mismatch, print a notice and return before validating config, writing files, saving config, committing or completing the update - Exit 0: a job that is not the target has nothing to do - No project_matches from an older server: behave as before - Real-filesystem test with two app folders, each with its own localhero.json * Run tests inside an agent worktree - Anchor the .claude ignore to <rootDir>, so the main checkout still skips worktree copies (#111) while a worktree no longer ignores itself - Before, npm test in .claude/worktrees/<name> found no tests at all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent worktrees under
.claude/worktrees/contain older copies oftests/, and Jest'stestMatchpicked them up: a localnpm testran 231 suites (4,296 tests) instead of the real 84 (1,454), so a stale copy could fail a release check for code that is fine.Adds
testPathIgnorePatterns: ['/node_modules/', '/.claude/']. Setting the option replaces Jest's default, so/node_modules/is kept explicitly.Verified:
jest --listTestsin a clone with two agent worktrees goes from 231 files to 84, none under.claude/ornode_modules/; full suite passes (1,454).