Repository navigation
Drop two placeholder false positives in check and fail on a source with no files - #118
Merged
Merged
Conversation
…th no files - A gettext plural form may use a placeholder only the plural source has - ICU arguments compare by presence, since # stands in for the number; Rails and i18next placeholders are still counted - --source with no files for that locale fails instead of reporting 100%
…ing source - The no-source guard fired on a broken en.yml, printed the wrong cause and left --json output empty - Guard only when nothing failed to parse; the parse-failure path already reports and fails the run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of localheroai/localhero-ai#829 (found in a 40-repo run of
checkover popular open-source apps).%(counter)swas flagged. The allowance is built once per catalog from all source forms of the entry. A placeholder missing from a form is still reported.{name}placeholders compare by presence, since ICU's#stands in for the plural argument. Rails%{}, i18next{{}}, Python and printf still compare counts, so a dropped repeat (a second%{days_in_month}) is still caught.--sourcewith no files for that locale now fails with a message instead of "0 keys, 100% complete". An unparseable source file still goes through the parse-failure path (reported, exit 1,--jsonstill printed).Verified
%{count}renamed to%{number}).--jsonoutput; fixed with a test.Not in this PR
a | bplural strings are still compared as one string.{aquí}are not recognised.{d} of {d}→{d}passes. Rare outside plurals; could be narrowed to names inside a reduced plural/select.