Repository navigation
Push only configured locales, and write new YAML plural forms in CLDR order - #132
Merged
Merged
Conversation
- Skip target files whose locale is not in outputLocales, with one log line naming the skipped locales - Share the source/target split between push and the initial import so both apply the same rule - Keep files that match a configured locale or the source locale up to case and separator - Return no_changes instead of calling the API when every file is skipped Claude-Session: https://claude.ai/code/session_01K8oRHjFQaCX7h3tszmBHyB
- Order each plural group's incoming categories as zero, one, two, few, many, other before writing - Reorder only within the slots those categories occupy, so other keys keep their position - Applies to splices, the full rewrite and new files; existing lines are untouched Claude-Session: https://claude.ai/code/session_01K8oRHjFQaCX7h3tszmBHyB
- splitFilesByLocale: name the skipped files instead of one long inline chain - yaml-handler: share last-segment extraction between pluralGroupOf and cldrRank Claude-Session: https://claude.ai/code/session_01K8oRHjFQaCX7h3tszmBHyB
- push skips locale files outside outputLocales - New YAML plural forms written in CLDR order Claude-Session: https://claude.ai/code/session_01K8oRHjFQaCX7h3tszmBHyB
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the next CLI release.
pushsends only configured localespushsent every locale file it found. One extra file next to the configured locales, such aspt.ymlorzh.yml, made the server reject the whole push with "One or more languages are not supported".outputLocalesare skipped, and one log line names them. The match ignores case and_/-.pushand the initial import share the same source/target split, so both follow one rule.pushreturnsno_changeswithout calling the API.New YAML plural forms in CLDR order
New plural forms came out in arrival order, for example
other:aboveone:. Each plural group's incoming forms are now ordered zero, one, two, few, many, other, within the slots they already occupy, so other keys stay where they are. Existing lines aren't touched.Tests
import-service.test.jsandyaml-plural-order.test.ts.Changelog entries are under
[Unreleased].