Updated for tag to use sort_by and order_by tags to allow sorting#1
Open
mobyjames wants to merge 55 commits into
Open
Updated for tag to use sort_by and order_by tags to allow sorting#1mobyjames wants to merge 55 commits into
mobyjames wants to merge 55 commits into
Conversation
…me causing some bugs
…er to understand + refactor / clean code
… ordering. All credit due entirely to shopfiy/liquid commit c5e9755, courtesy of @KeeperPat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added a sort feature for the 'for' tag based on the sort feature already present in the main shopify/liquid repo. The appropriate commit/pull request is mentioned in the commit message, just for reference.
The syntax is identical, e.g.
{% for tag in post.tags sort_by: name order: descending %}
{{ tag.name }}
{% endfor %}
We believe this feature adds a great deal of functionality when accessing relationships, as in the above example.