-
Notifications
You must be signed in to change notification settings - Fork 9
feat!(prepro, config): assign segment with nextclade sort #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
anna-parker
wants to merge
28
commits into
move_fast_header_validation
from
prepro_config_multi_path
Closed
feat!(prepro, config): assign segment with nextclade sort #4783
anna-parker
wants to merge
28
commits into
move_fast_header_validation
from
prepro_config_multi_path
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
commented
Jul 31, 2025
preprocessing/nextclade/src/loculus_preprocessing/new_config.yaml
Outdated
Show resolved
Hide resolved
anna-parker
commented
Aug 1, 2025
d18816c to
61e3123
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anna-parker
commented
Aug 4, 2025
...nd/src/main/kotlin/org/loculus/backend/service/submission/ProcessedSequenceEntryValidator.kt
Outdated
Show resolved
Hide resolved
...nd/src/main/kotlin/org/loculus/backend/service/submission/ProcessedSequenceEntryValidator.kt
Show resolved
Hide resolved
bda04db to
b129f55
Compare
61e3123 to
141a825
Compare
1afe3fd to
12eb7b5
Compare
141a825 to
0f15fe1
Compare
e52e614 to
97e34b4
Compare
6f28988 to
9472216
Compare
6232be6 to
a0242c5
Compare
f69d2ac to
48d8110
Compare
fc76c68 to
997af9c
Compare
3d4d2dd to
8142ff0
Compare
bec5cdc to
fa2cd75
Compare
1 task
5 tasks
This was referenced Nov 10, 2025
Contributor
Author
|
closing in favor of #5402 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4847
Screenshot
Builds on #4821
You can use pathoplexus/dev_example_data#2 for testing - see example submission in video:
Screen.Recording.2025-08-12.at.13.43.15.mov
Enable assignment of segments/subtypes using nextclade sort with the param:
When this is set to true (per default) fasta headers must have the format _ (as in current set up).
Additionally instead of having a dictionary for the nextclade datasets and servers we make
nucleotideSequencesa list of sequences:Note the templates now also generate the genes list from the merged config.
PR Checklist
🚀 Preview: Add
previewlabel to enable