feat(website): show sequence specific filters without requiring an associated segment#6108
feat(website): show sequence specific filters without requiring an associated segment#6108anna-parker merged 6 commits intomainfrom
Conversation
|
Claude finished @anna-parker's task in 1m 38s —— View job Code Review
The website logic looks correct. The One thing to be aware of: for single-segment organisms, 'ALL' fields will appear above the single segment's content. Depending on UX intent, this seems fine.
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bfc5b3160
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2bfc5b3 to
5bf43c0
Compare
maverbiest
left a comment
There was a problem hiding this comment.
Looks good!
Not blocking, but I personally find the 'ALL' keyword slightly confusing. Would something like 'UNASSIGNED' or 'NO_SEGMENT' be an option?
|
I switched to |
|
goodness the integration tests are so flaky! |
Co-authored-by: Anna (Anya) Parker <50943381+anna-parker@users.noreply.github.com>
resolves #5993
Screenshot
tested on preview, integration tests are failing due to issues with pulling the docker images - I will restart them
🚀 Preview: https://allowsequencedatawithouts.loculus.org