Skip to content

feat(website): show sequence specific filters without requiring an associated segment#6108

Merged
anna-parker merged 6 commits intomainfrom
allowSequenceDataWithoutSeg
Mar 19, 2026
Merged

feat(website): show sequence specific filters without requiring an associated segment#6108
anna-parker merged 6 commits intomainfrom
allowSequenceDataWithoutSeg

Conversation

@anna-parker
Copy link
Copy Markdown
Contributor

@anna-parker anna-parker commented Mar 10, 2026

resolves #5993

Screenshot

image

tested on preview, integration tests are failing due to issues with pulling the docker images - I will restart them

🚀 Preview: https://allowsequencedatawithouts.loculus.org

@claude claude bot added the website Tasks related to the web application label Mar 10, 2026
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Mar 10, 2026
@anna-parker anna-parker marked this pull request as ready for review March 10, 2026 15:42
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 10, 2026

Claude finished @anna-parker's task in 1m 38s —— View job


Code Review

  • Gather context
  • Review changes
  • Post feedback

The website logic looks correct. The 'ALL' key is used as a virtual bucket for isSequenceFilter fields that don't have a relatesToSegment value, and they're rendered at the top of the Sequence Filters section before the per-segment content. The guards added to renderSegmentContents (segmentName !== 'ALL') correctly prevent the ReferenceSelector and MutationField from being rendered for that virtual segment (since segmentAndGeneInfo['ALL'] would be undefined anyway, the mutation field guard was arguably redundant but adding it explicitly is clearer).

One thing to be aware of: for single-segment organisms, 'ALL' fields will appear above the single segment's content. Depending on UX intent, this seems fine.

kubernetes/loculus/values.yaml: The isSequenceFilter: true # revert after testing line on hostNameScientific is a testing artifact — left an inline comment. This must be removed before merging.

@anna-parker anna-parker changed the title feat(website): show sequence specific filters without associated segment feat(website): show sequence specific filters without requiring an associated segment Mar 10, 2026
@theosanderson
Copy link
Copy Markdown
Member

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2bfc5b3160

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anna-parker anna-parker removed the preview Triggers a deployment to argocd label Mar 15, 2026
@anna-parker anna-parker force-pushed the allowSequenceDataWithoutSeg branch from 2bfc5b3 to 5bf43c0 Compare March 16, 2026 14:58
Copy link
Copy Markdown
Contributor

@maverbiest maverbiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Not blocking, but I personally find the 'ALL' keyword slightly confusing. Would something like 'UNASSIGNED' or 'NO_SEGMENT' be an option?

@anna-parker
Copy link
Copy Markdown
Contributor Author

I switched to NO_ASSIGNED_SEGMENT :-)

@anna-parker anna-parker requested a review from maverbiest March 19, 2026 10:12
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Mar 19, 2026
@anna-parker
Copy link
Copy Markdown
Contributor Author

goodness the integration tests are so flaky!

Co-authored-by: Anna (Anya) Parker <50943381+anna-parker@users.noreply.github.com>
@anna-parker anna-parker merged commit e1c77d4 into main Mar 19, 2026
37 checks passed
@anna-parker anna-parker deleted the allowSequenceDataWithoutSeg branch March 19, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Triggers a deployment to argocd website Tasks related to the web application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchUI: add option to show sequence filters that are not segment-related

3 participants