chore(silo, lapis, website): update lapis to v0.8.0, silo to v0.11.0#6146
chore(silo, lapis, website): update lapis to v0.8.0, silo to v0.11.0#6146anna-parker merged 17 commits intomainfrom
Conversation
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts
Outdated
Show resolved
Hide resolved
19c626f to
04c9956
Compare
|
Claude finished @anna-parker's task in 2m 21s —— View job Code Review
The overall approach is correct — using One bug found (left as an inline comment on Everything else looks good — the |
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts
Outdated
Show resolved
Hide resolved
chaoran-chen
left a comment
There was a problem hiding this comment.
This looks good to me, thanks very much!
resolves #2679
Now in the case of multi-segmented organisms we do not download empty sequences as a long Ns string when we download all aligned sequences of a specific segment, but instead just download the sequences for entries where this segment exists - a much needed improvement!!
Update to LAPIS v0.7.0: https://github.com/GenSpectrum/LAPIS/releases/tag/v0.7.0 and then https://github.com/GenSpectrum/LAPIS/releases/tag/v0.8.0 which adds escaping in advanced queries, this update includes a breaking change where LAPIS treats
NULLdifferently than the empty string.We have used these fields interchangeably we need to update our calls: Exact filters for
field=nullshould be modified tofield.isNull=true. Null values in an array can still be sent too LAPIS in POST requests but not in GET requests e.g.country=[Australia, null], instead they should be converted into an advanced query:"advancedQuery": "IsNull(field) OR field='Australia'". As downloads use GET requests this PR adds a new function to convert values with NULL into advanced queries.How do I get the SHAs?
I run
PR Checklist
I added O'Conner to the URL: https://update-lapis-silo.loculus.org/ebola-sudan/search?visibility_authors=true&geoLocCountry=Canada&geoLocCountry=O%27Conner&geoLocCountry=_null_
and then checked that the download (POST) request to LAPIS works and returns results: https://lapis-update-lapis-silo.loculus.org/ebola-sudan/sample/details?downloadAsFile=true&downloadFileBasename=ebola-sudan_metadata_2026-03-20T1042&dataUseTerms=OPEN&dataFormat=tsv&fields=accessionVersion%2CsampleCollectionDate%2CgeoLocCountry%2Cauthors%2CsubmissionId%2CgroupName%2CdataUseTerms%2CdataUseTermsUrl%2CauthorAffiliations%2CearliestReleaseDate&versionStatus=LATEST_VERSION&isRevocation=false&advancedQuery=isNull%28geoLocCountry%29+OR+geoLocCountry%3D%27Canada%27+OR+geoLocCountry%3D%27O%5C%27Conner%27
🚀 Preview: https://update-lapis-silo.loculus.org