Skip to content

chore(silo, lapis, website): update lapis to v0.8.0, silo to v0.11.0#6146

Merged
anna-parker merged 17 commits intomainfrom
update_lapis_silo
Mar 26, 2026
Merged

chore(silo, lapis, website): update lapis to v0.8.0, silo to v0.11.0#6146
anna-parker merged 17 commits intomainfrom
update_lapis_silo

Conversation

@anna-parker
Copy link
Copy Markdown
Contributor

@anna-parker anna-parker commented Mar 16, 2026

resolves #2679

Now in the case of multi-segmented organisms we do not download empty sequences as a long Ns string when we download all aligned sequences of a specific segment, but instead just download the sequences for entries where this segment exists - a much needed improvement!!

Update to LAPIS v0.7.0: https://github.com/GenSpectrum/LAPIS/releases/tag/v0.7.0 and then https://github.com/GenSpectrum/LAPIS/releases/tag/v0.8.0 which adds escaping in advanced queries, this update includes a breaking change where LAPIS treats NULL differently than the empty string.

We have used these fields interchangeably we need to update our calls: Exact filters for field=null should be modified to field.isNull=true. Null values in an array can still be sent too LAPIS in POST requests but not in GET requests e.g. country=[Australia, null], instead they should be converted into an advanced query: "advancedQuery": "IsNull(field) OR field='Australia'". As downloads use GET requests this PR adds a new function to convert values with NULL into advanced queries.

How do I get the SHAs?

I run

$ docker pull ghcr.io/genspectrum/lapis:0.8.0 
0.8.0: Pulling from genspectrum/lapis
afe150872799: Pull complete 
65d5c9ef4c7e: Pull complete 
b998a17eab92: Pull complete 
810318c22279: Pull complete 
d4d14ce49924: Download complete 
Digest: sha256:4da71d94aceb36b7ea5963aa2e7b0566567c6423fe7fdd39448e69aebda2a8bb
Status: Downloaded newer image 

PR Checklist

🚀 Preview: https://update-lapis-silo.loculus.org

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Mar 16, 2026
@claude claude bot added deployment Code changes targetting the deployment infrastructure silo/LAPIS upstream silo/LAPIS issue labels Mar 16, 2026
@anna-parker anna-parker marked this pull request as ready for review March 17, 2026 16:15
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 17, 2026

Claude finished @anna-parker's task in 2m 21s —— View job


Code Review

  • Read changed files
  • Analyze code quality and correctness
  • Post review feedback

The overall approach is correct — using NULL_QUERY_VALUE as a sentinel in toUrlSearchParams() and converting it at the GET request boundary in modifyParamsForLapisGetRequest is clean and well-structured. The removal of the unused lapisSilo image from values.yaml is the right cleanup.

One bug found (left as an inline comment on DownloadUrlGenerator.ts:112): values inside the advanced query clause are currently unquoted. Any value containing spaces (e.g. country = "United States") would produce country=United States, which LAPIS will likely reject or misparse. The fix is to wrap values in single quotes: `${name}='${v}'`.

Everything else looks good — the isNull param for single-null fields, the advancedQuery merging logic for multiple fields, and the test coverage are all solid.

@anna-parker anna-parker removed the preview Triggers a deployment to argocd label Mar 19, 2026
@anna-parker anna-parker changed the title chore(silo, lapis, website): update lapis to v0.7.0, silo to v0.11.0 chore(silo, lapis, website): update lapis to v0.8.0, silo to v0.11.0 Mar 20, 2026
@anna-parker anna-parker added the preview Triggers a deployment to argocd label Mar 20, 2026
@theosanderson theosanderson removed the preview Triggers a deployment to argocd label Mar 20, 2026
@chaoran-chen chaoran-chen added the preview Triggers a deployment to argocd label Mar 26, 2026
Copy link
Copy Markdown
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks very much!

@anna-parker anna-parker merged commit e1b367f into main Mar 26, 2026
71 checks passed
@anna-parker anna-parker deleted the update_lapis_silo branch March 26, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Code changes targetting the deployment infrastructure preview Triggers a deployment to argocd silo/LAPIS upstream silo/LAPIS issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-segmented organisms missing a segment: aligned sequences still show up as all Ns and are in the downloaded files.

3 participants