Skip to content

Conversation

@mayooot
Copy link
Contributor

@mayooot mayooot commented Dec 26, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #3379


Note

Ensures correct URL rewriting in the registry reverse proxy to avoid malformed paths and redirects.

  • Refactors inline replaceHost into newHostRewriter to consistently rewrite target to http://<newHost>/
  • Updates replacement to include a trailing slash after the port (e.g., http://127.0.0.1:15000/)
  • Adds proxy_test.go with TestNewHostRewriterAddsSlashAfterPort to verify the rewrite behavior
  • Applies the new rewriter in proxy.go via rewriteHeaderTransport.replaceHost

Written by Cursor Bugbot for commit 4283137. This will update automatically on new commits. Configure here.

@mayooot mayooot requested a review from a team as a code owner December 26, 2025 06:28
@cbron cbron merged commit f5acad0 into loft-sh:main Jan 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vcluster registry proxy missing first slash in URL after port

3 participants