fix(assets): multi arch support for scripts #3448
Closed
+153
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
sydorovdmytro
force-pushed
the
fix-assets-scripts
branch
from
cc97ef2 to
ef95c87
Compare
Fixes an issue when multi-arch Docker images are pulled/pushed as linux/amd64 only. It causes issues for multi-arch Air-gapped setups.
sydorovdmytro
force-pushed
the
fix-assets-scripts
branch
from
ef95c87 to
1236094
Compare
Contributor
Author
|
Closing in favor of #3454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when multi-arch Docker images are pulled/pushed as linux/amd64 only.
It causes issues for multi-arch Air-gaped setups.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-10853
Note
Enables multi-arch image mirroring by switching scripts to a skopeo + OCI-directory workflow.
assets/download-images.shto useskopeo copy --alland store each image as an OCI directory (safe filename), preserving manifest lists; removes--platform, adds sanity checks, counters, and optional tarball packaging instructionsassets/push-images.shto push from OCI directories withskopeo copy --all; supports--insecure(TLS skip), auto-extracts.tar.gzbundles, normalizes--registry(strips protocol), uses embeddedimages.txtby default, and maps image refs to target registryWritten by Cursor Bugbot for commit 1236094. This will update automatically on new commits. Configure here.