fix: remove automatic relay unsubscribe in a goroutine#1284
Merged
igor-sirotin merged 2 commits intomasterfrom May 28, 2025
Merged
fix: remove automatic relay unsubscribe in a goroutine#1284igor-sirotin merged 2 commits intomasterfrom
igor-sirotin merged 2 commits intomasterfrom
Conversation
igor-sirotin
force-pushed
the
fix/remove-auto-unsubscribe
branch
from
c1d9b9a to
aabd99e
Compare
richard-ramos
approved these changes
May 26, 2025
Member
richard-ramos
left a comment
richard-ramos
left a comment
There was a problem hiding this comment.
Should be okay to remove the the ctx parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've removed this:
https://github.com/waku-org/go-waku/blob/8b0e03113db6db3dcd2fbef9a97380f2b8631098/waku/v2/protocol/relay/waku_relay.go#L441-L445
Because the client will call
Unsubscribein the end anyway.At the same time for current implementation we need to provide some
ctx, which is complicatingstatus-gocode.I've kept the
ctxargument forSubscribeandUnsubscribenot to break compatibility.Also added a getter for
Subscription.contentFilterto simplify status-go code