fix: handle precompile reverts correctly #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@klkvr revm has new release are you planing to finish this PR ? |
mattsse
approved these changes
Jul 29, 2025
Collaborator
|
yep should require using reth main and latest alloy-evm release |
will-2012
reviewed
Jul 29, 2025
| // basic check | ||
| if header1.number.to_be_bytes().len() > 32 || header2.number.to_be_bytes().len() > 32 { | ||
| return Err(BscPrecompileError::DoubleSignInvalidEvidence.into()); | ||
| return revert() |
Contributor
Collaborator
Author
There was a problem hiding this comment.
what did the #44 change exactly? before this PR Reverted variant had same effect as DoubleSignInvalidEvidence
Contributor
There was a problem hiding this comment.
staticcall_0_1 returns the InvalidEvidence.
I will check the specific impact of this during the next round of testnet resync.
Contributor
|
Fixed #30. |
will-2012
referenced
this pull request
in will-2012/reth-bsc
Sep 3, 2025
chore: resolve conflicts with develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on revm release with bluealloy/revm#2711