This repository was archived by the owner on Dec 7, 2020. It is now read-only.
Use end-session-endpoint in logout redirects if it exists#619
Open
gps035 wants to merge 3 commits intolouketo:masterfrom
Open
Use end-session-endpoint in logout redirects if it exists#619gps035 wants to merge 3 commits intolouketo:masterfrom
gps035 wants to merge 3 commits intolouketo:masterfrom
Conversation
abstractj
suggested changes
Jun 3, 2020
abstractj
left a comment
abstractj
left a comment
There was a problem hiding this comment.
For any changes into the codebase we need to add tests for it, but prior to do that. Let's discuss the motivation for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When logging out, this change will cause a redirect to the
end_session_endpointfrom the discovery doc if that endpoint is specified, and if theenable-logout-redirectoption is selected.Type
[x] Bug fix
[] Feature request
[] Enhancement
[] Docs
Why?
If the issuer does not have an end session endpoint matching
$ISSUER/protocol/openid-connect/logout, then a user will most likely be redirected to an invalid pageChecklist: