[otlib] QEMU transport GPIO interface #28413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
force-pushed
the
earlgrey-1.0.0-qemu-gpio
branch
4 times, most recently
from
cceb1c8 to
8e93c3f
Compare
AlexJones0
reviewed
Oct 9, 2025
Comment on lines
129
to
131
| /// * `I:<value>`: the Inputs to the device's pads are now `<value>`. | ||
| /// * `M:<value>`: the inputs are Masked with `<value>`, meaning connected. | ||
| /// * `R:00000000`: ask QEMU to Repeat the last `d` and `o` frames (see [`process_frames`]). |
There was a problem hiding this comment.
Maybe could be clearer?
Suggested change
| /// * `I:<value>`: the Inputs to the device's pads are now `<value>`. | |
| /// * `M:<value>`: the inputs are Masked with `<value>`, meaning connected. | |
| /// * `R:00000000`: ask QEMU to Repeat the last `d` and `o` frames (see [`process_frames`]). | |
| /// * `I:<value>`: the inputs to the device's pads are now `<value>`, if driven. | |
| /// * `M:<value>`: the inputs are masked with `<value>`, meaning driven/connected. | |
| /// * `R:00000000`: ask QEMU to repeat the last `D` and `O` frames (see [`process_frames`]). |
There was a problem hiding this comment.
You missed some of the last line here (extra spacing, and capitalization).
| # If real bootstrapping is requested then prepare the correct command, otherwise we need | ||
| # to prepare a QEMU drive containing flash contents. | ||
| if param["bootstrap"] and json.decode(param["bootstrap"]): | ||
| test_script_fmt |= {"flash": ""} |
There was a problem hiding this comment.
Should this maybe still prepare a blank flash image via flashgen, as presumably if we add info page splicing via flashgen in the future we will still want do this? This will also ensure that the flash image flows are the same for bootstrapping vs splicing firmware.
AlexJones0
reviewed
Oct 9, 2025
jwnrt
force-pushed
the
earlgrey-1.0.0-qemu-gpio
branch
from
5f3e548 to
8555d22
Compare
jwnrt
requested review from
pamaury
and removed request for
a team and
cfrantz
Signed-off-by: James Wainwright <[email protected]>
Includes fixes for GPIO over reset and SPI payload uploading. Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
earlgrey-1.0.0-qemu-gpio
branch
from
8555d22 to
de9b601
Compare
AlexJones0
reviewed
Oct 9, 2025
|
|
||
| mode: Cell<PinMode>, | ||
|
|
||
| /// Pull mod of the current pin. |
There was a problem hiding this comment.
Suggested change
| /// Pull mod of the current pin. | |
| /// Pull mode of the current pin. |
| if param["bootstrap"] and json.decode(param["bootstrap"]): | ||
| test_script_fmt |= {"flash": ""} | ||
| bootstrap_cmd = "bootstrap --clear-uart=true --reset-delay 1000ms {firmware}".format(**param) | ||
| param["bootstrap_cmd"] = '--exec="{}"'.format(bootstrap_cmd) |
There was a problem hiding this comment.
Can you add a fail if we try to give a bootstrap = True when using a custom test harness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an interface to the GPIO block and enables bootstrapping.
Bootstrapping is fairly slow, so I have set up the exec env to skip it by default and load a pre-prepared drive. You can opt in by adding
bootstrap = Trueto theqemu_paramsor manually bootstrapping in a test harness.Currently blocked on a QEMU change.