[sw,silicon_creator] Move key seed retrieval function to top specific folders #28439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameo
requested review from
pamaury and
timothytrippel
and removed request for
a team
sameo
force-pushed
the
topic/multi-top/otbn-services
branch
2 times, most recently
from
823a594 to
3fa79d0
Compare
sameo
force-pushed
the
topic/multi-top/otbn-services
branch
2 times, most recently
from
898e6f3 to
6c28cc8
Compare
pamaury
reviewed
Oct 8, 2025
pamaury
reviewed
Oct 8, 2025
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| cc_library( | ||
| name = "hooks", |
There was a problem hiding this comment.
I think hooks might be too general a name but I don't have a suggestion for another name. Not very important, can be changed later
pamaury
reviewed
Oct 8, 2025
pamaury
reviewed
Oct 8, 2025
pamaury
requested review from
AlexJones0,
a-will,
cfrantz,
engdoreis and
moidx
… folders Not all tops require or provide an additional attestation key seed, make the function a top specific implementation. This removes the flash controller dependency from the OTBN boot services library. Partly fixes lowRISC#28438 Signed-off-by: Samuel Ortiz <[email protected]>
sameo
force-pushed
the
topic/multi-top/otbn-services
branch
from
6c28cc8 to
77d463d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all tops require or provide an additional attestation key seed, make the function a top specific implementation.
This removes the flash controller dependency from the OTBN boot services library.
Fixes #28438