[util,toolchain] Download toolchain architecture specific #28443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer releases of the lowRISC maintained RISC-V toolchain contain builds for different architectures whereas older releases targeted only one architecture. This change adds a switch to the util/get-toolchain.py script to select the desired architecture. Signed-off-by: Pascal Etterli <[email protected]>
|
Thanks Pascal - I can confirm that this solves the issue with the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer releases of the lowRISC maintained RISC-V toolchain contain builds for different architectures whereas older releases targeted only one architecture.
This change adds a switch to the
util/get-toolchain.pyscript to select the desired architecture.I opted for a manual architecture selection and chose
x86_64as default architecture. Is there a need to add an automatic architecture detection (i.e., somehow detecting the architecture of the host calling the script)?This closes #26575.