Quiz exercises: Fix 'Invalid Input' persisting after deleting and restoring the only question

[MaximilianAnzinger]

Summary

Fixes #12475. When re-evaluating a quiz, deleting all questions (or the only question) and then clicking Reset Quiz to restore them left the "Invalid Input" badge permanently visible — even though the quiz was fully valid again after the reset.

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
• I strictly followed the principle of data economy for all client-server REST calls.
• I strictly followed the client coding guidelines.
• I added multiple integration tests (Vitest) related to the features (with a high test coverage), while following the test guidelines.

Motivation and Context

Fixes #12475.

In the re-evaluate flow (QuizReEvaluateComponent), the resetAll() method clones savedEntity back into quizExercise — effectively restoring any questions that were previously deleted. However, it never called cacheValidation(), so the cached validation state (quizIsValid, invalidReasons) remained stale from when the questions were deleted. As a result, the "Invalid Input" badge kept showing the "The quiz has no questions" message even after the questions had been restored.

Description

Root cause: resetAll() in quiz-re-evaluate.component.ts only restored quizExercise from savedEntity but omitted the cacheValidation(this.changeDetector) call that updates quizIsValid and invalidReasons.

Fix: Added this.cacheValidation(this.changeDetector) at the end of resetAll(). This is a one-line change mirroring what every other mutation in this component already does (e.g. deleteQuestion, onQuestionUpdated).

Test added: A new Vitest test in quiz-re-evaluate.component.spec.ts that:

1. Deletes all questions → asserts quizIsValid === false
2. Calls resetAll() → asserts questions are restored and quizIsValid === true

Steps for Testing

Prerequisites:

• 1 Instructor account
• 1 Quiz exercise that has already ended (so the Re-evaluate button is available)

1. Log in as Instructor.
2. Navigate to the course → Exercises → the finished quiz exercise.
3. Click Re-evaluate (wrench icon).
4. Delete the only (or all) question(s) using the trash icon.
5. Observe the "Invalid Input" badge appears with the message "The quiz has no questions".
6. Click the Reset Quiz button.
7. ✅ Expected: The badge disappears and the quiz is shown as valid again.
8. ❌ Before fix: The badge persisted even though the question was visible.

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Lines	Expects	Ratio
quiz-re-evaluate.component.ts	84.12%	156	31	19.9

Last updated: 2026-04-16 09:34:21 UTC

[github-actions]

@MaximilianAnzinger Test coverage has been automatically updated in the PR description.

[coderabbitai]

Walkthrough

The changes address a validation state bug in quiz re-evaluation by ensuring that the resetAll() method re-caches validation after restoring the quiz exercise. A unit test is added to verify that validation state is correctly updated when questions are deleted and the reset operation is performed.

Changes

Cohort / File(s)	Summary
Component validation fix src/main/webapp/app/quiz/manage/re-evaluate/quiz-re-evaluate.component.ts	Added cacheValidation() call in resetAll() method to update validation state after restoring the quiz exercise from saved state.
Component test src/main/webapp/app/quiz/manage/re-evaluate/quiz-re-evaluate.component.spec.ts	Added unit test verifying that resetAll() correctly restores questions and fixes validation state after all questions are deleted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The code changes directly address issue #12475 by adding validation caching in resetAll() and testing the fix with a unit test.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the validation state issue; no unrelated modifications are present in the component or test files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and specifically describes the main bug being fixed: the 'Invalid Input' validation persisting after deleting and restoring questions in quiz exercises.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/quiz/invalid-input

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

End-to-End Test Results

Phase	Status	Details
Phase 1 (Relevant)	✅ Passed	Tests Passed ✅ Skipped ⚠️ Failed Time ⏱ Phase 1: E2E Test Report 37 ran 36 passed 1 skipped 0 failed 7m 46s
Phase 2 (Remaining)	❌ Failed	Tests Passed ☑️ Skipped ⚠️ Failed ❌️ Time ⏱ Phase 2: E2E Test Report 215 ran 213 passed 1 skipped 1 failed 34m 13s

Test Strategy: Two-phase execution

• Phase 1: e2e/Login.spec.ts e2e/Logout.spec.ts e2e/SystemHealth.spec.ts e2e/exercise/quiz-exercise/
• Phase 2: e2e/atlas/ e2e/course/ e2e/exam/ExamAssessment.spec.ts e2e/exam/ExamChecklists.spec.ts e2e/exam/ExamCreationDeletion.spec.ts e2e/exam/ExamDateVerification.spec.ts e2e/exam/ExamManagement.spec.ts e2e/exam/ExamParticipation.spec.ts e2e/exam/ExamResults.spec.ts e2e/exam/ExamTestRun.spec.ts e2e/exam/test-exam/ e2e/exercise/ExerciseImport.spec.ts e2e/exercise/file-upload/ e2e/exercise/modeling/ e2e/exercise/programming/ e2e/exercise/text/ e2e/lecture/

Overall: ❌ Phase 2 (remaining tests) failed

🔗 Workflow Run · 📊 Test Report

[Claudia-Anthropica]

@MaximilianAnzinger Clean fix — resetAll() was the only mutation missing the cacheValidation() call. The new test covers the exact bug scenario nicely. Approving as-is.

[SedaOran]

Hi @MaximilianAnzinger ,
Thanks for the clean fix, the validation issue and the added test make sense.

I had one question regarding the behavior after clicking Reset Quiz: once the questions are restored, the Save button remains disabled if no further changes are made. Only after modifying the quiz again does it become enabled.

Is this the expected behavior (i.e., no changes → nothing to save), or should resetting also mark the quiz as having pending changes so it can be saved immediately? Just wanted to clarify whether this is intentional or something we might want to revisit.

Thanks!