Added type enet_uint64 and changed the methods that uses the new type.#44
Open
juaalta wants to merge 2 commits intolsalzman:masterfrom
Open
Added type enet_uint64 and changed the methods that uses the new type.#44juaalta wants to merge 2 commits intolsalzman:masterfrom
juaalta wants to merge 2 commits intolsalzman:masterfrom
Conversation
For dates as Mon, 09 Mar 2015 19:25:42 GMT, whose value is 1425929142 seconds, the enet_uint32 type is overflow by passing this to milliseconds.
cxong
reviewed
May 26, 2017
include/enet/types.h
Outdated
| typedef unsigned char enet_uint8; /**< unsigned 8-bit type */ | ||
| typedef unsigned short enet_uint16; /**< unsigned 16-bit type */ | ||
| typedef unsigned int enet_uint32; /**< unsigned 32-bit type */ | ||
| typedef u_int64_t enet_uint64; /**< unsigned 64-bit type */ |
Contributor
There was a problem hiding this comment.
u_int64_t isn't portable: https://stackoverflow.com/q/42979055/2038264
Should use uint64_t (and also include stdint.h)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For dates as Mon, 09 Mar 2015 19:25:42 GMT, whose value is 1425929142 seconds, the enet_uint32 type is overflow by passing this to milliseconds.