Skip to content

DM-54126: Change to use shared buildx builder instead of recreating for each build#462

Merged
stvoutsin merged 1 commit intomainfrom
tickets/DM-54126
Feb 12, 2026
Merged

DM-54126: Change to use shared buildx builder instead of recreating for each build#462
stvoutsin merged 1 commit intomainfrom
tickets/DM-54126

Conversation

@stvoutsin
Copy link
Contributor

@stvoutsin stvoutsin commented Feb 11, 2026

Description

The tap-schema/build script creates and destroys a fresh buildx builder on every run.
build-all calls it 15 times and each time the new builder has to pull the mysql base image for 2 platforms from Docker.
That would lead to 30+ pulls per CI run including other pulls.

Fix

Create builder and delete it once in the build-all script.

Note: I've also changed the build script to also create it if it doesn't exist, to allow build to be run in isolation. If the intention is that this never should happen, we could remove that since the build-all script will always have created the builder.

Checklist

When making changes to YAML files in the schemas directory:

@stvoutsin stvoutsin marked this pull request as ready for review February 11, 2026 21:48
@stvoutsin stvoutsin marked this pull request as draft February 11, 2026 21:56
@stvoutsin stvoutsin marked this pull request as ready for review February 12, 2026 18:26
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing!

@stvoutsin stvoutsin merged commit cdffd4b into main Feb 12, 2026
15 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-54126 branch February 12, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants