DM-54126: Change to use shared buildx builder instead of recreating for each build#462
Merged
DM-54126: Change to use shared buildx builder instead of recreating for each build#462
Conversation
fffcad2 to
f3b1b2d
Compare
f3b1b2d to
74cd04d
Compare
JeremyMcCormick
approved these changes
Feb 12, 2026
Collaborator
JeremyMcCormick
left a comment
There was a problem hiding this comment.
Great, thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tap-schema/build script creates and destroys a fresh buildx builder on every run.
build-allcalls it 15 times and each time the new builder has to pull the mysql base image for 2 platforms from Docker.That would lead to 30+ pulls per CI run including other pulls.
Fix
Create builder and delete it once in the build-all script.
Note: I've also changed the build script to also create it if it doesn't exist, to allow build to be run in isolation. If the intention is that this never should happen, we could remove that since the build-all script will always have created the builder.
Checklist
When making changes to YAML files in the schemas directory: