DM-55695: Add psfArea, psfIxx, psfIxy, psfIyy columns to VisitDetector. - #522
Conversation
|
@laurenam should still do the review, of course, but just as a comment: This is exactly consistent with the new column-schema-referencing style and does not have any effect on the DP2 schema or force it to be "frozen" yet. |
51833aa to
2d23d68
Compare
| - name: psfIxy | ||
| description: PSF model second-moments Ixy (center of chip) | ||
| datatype: double | ||
| ivoa:unit: pixel**2 |
There was a problem hiding this comment.
Do these really need to be double? (I see psfSigma is float above).
There was a problem hiding this comment.
They are produced as double. If we had any unit tests of these I think they'd show that psfSigma has a mismatch.
I don't know what the plans are here, so I wanted to keep them matched to what was produced.
Fortunately, these are per-detector and not per-object.
2d23d68 to
fafd6d4
Compare
|
@erykoff Can you give us a one-sentence summary of this change so that we can patch in the (required) news fragment file for the next round of release notes? "Added per-detector PSF shape metrics to VisitDetector in DRP development schemas" is fine unless you want to be more specific. #526 is ready to go, you can comment/suggest there if you don't like the summary. |
Checklist
When making changes to YAML files in the schemas directory: