Skip to content

DM-55695: Add psfArea, psfIxx, psfIxy, psfIyy columns to VisitDetector. - #522

Merged
erykoff merged 1 commit into
mainfrom
tickets/DM-55695
Aug 11, 2026
Merged

erykoff merged 1 commit into
mainfrom
tickets/DM-55695

Conversation

@erykoff

@erykoff erykoff commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Checklist

When making changes to YAML files in the schemas directory:

@erykoff
erykoff requested a review from laurenam August 7, 2026 17:19
@gpdf

gpdf commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

@laurenam should still do the review, of course, but just as a comment:

This is exactly consistent with the new column-schema-referencing style and does not have any effect on the DP2 schema or force it to be "frozen" yet.

@laurenam laurenam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apdb.yaml‎? Also, they like a news fragment à la 8fc103f to be added.

- name: psfIxy
description: PSF model second-moments Ixy (center of chip)
datatype: double
ivoa:unit: pixel**2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these really need to be double? (I see psfSigma is float above).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are produced as double. If we had any unit tests of these I think they'd show that psfSigma has a mismatch.

I don't know what the plans are here, so I wanted to keep them matched to what was produced.

Fortunately, these are per-detector and not per-object.

@erykoff
erykoff merged commit 73a14eb into main Aug 11, 2026
16 checks passed
@erykoff
erykoff deleted the tickets/DM-55695 branch August 11, 2026 16:40
@gpdf

gpdf commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@erykoff Can you give us a one-sentence summary of this change so that we can patch in the (required) news fragment file for the next round of release notes?

"Added per-detector PSF shape metrics to VisitDetector in DRP development schemas" is fine unless you want to be more specific.

#526 is ready to go, you can comment/suggest there if you don't like the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants