Skip to content

DM-54475: Remove validityEndMjdTai column from DiaObject table in PPDB schema - #524

Merged
JeremyMcCormick merged 3 commits into
mainfrom
tickets/DM-54475
Aug 21, 2026
Merged

JeremyMcCormick merged 3 commits into
mainfrom
tickets/DM-54475

Conversation

@JeremyMcCormick

@JeremyMcCormick JeremyMcCormick commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

NB: This is NOT to be back ported to v30.

Jira: DM-54475

Checklist

When making changes to YAML files in the schemas directory:

@JeremyMcCormick
JeremyMcCormick force-pushed the tickets/DM-54475 branch 2 times, most recently from 74ccebb to 7857425 Compare August 11, 2026 18:07
@JeremyMcCormick
JeremyMcCormick requested a review from gpdf August 11, 2026 20:16

@gpdf gpdf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though maybe if the DiaObject table in this schema really only is supposed to be the "latest" versions, the table description should be changed?

@JeremyMcCormick

Copy link
Copy Markdown
Collaborator Author

Seems fine, though maybe if the DiaObject table in this schema really only is supposed to be the "latest" versions, the table description should be changed?

The description still seems accurate:

description: Astronomical objects detected on one or more difference images

Do you want me to add something like "containing only the latest record versions"?

@gpdf

gpdf commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Do you want me to add something like "containing only the latest record versions"?

Yes, please, because it's different from DiaObject tables that people might encounter elsewhere. When you add the "with the history" table, its description should mirror this one so that users of either are aware of the issue.

@JeremyMcCormick

Copy link
Copy Markdown
Collaborator Author

Do you want me to add something like "containing only the latest record versions"?

Yes, please, because it's different from DiaObject tables that people might encounter elsewhere. When you add the "with the history" table, its description should mirror this one so that users of either are aware of the issue.

I've updated to:

  description: Astronomical objects detected on one or more difference images,
    containing only the latest record versions with an open validity interval

Comment thread python/lsst/sdm/schemas/ppdb.yaml Outdated

@gpdf gpdf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested new wording

Comment thread python/lsst/sdm/schemas/ppdb.yaml Outdated
@JeremyMcCormick
JeremyMcCormick merged commit bbb8cfd into main Aug 21, 2026
16 checks passed
@JeremyMcCormick
JeremyMcCormick deleted the tickets/DM-54475 branch August 21, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants