[DM-31056] Stop attempting to get user's full name #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing the user's name in an HTTP header, but HTTP headers only truly support ASCII (and, if not ASCII, use ISO 8859-1). This means we cannot represent many people's names. Rather than use a more complicated encoding solution to pass the name down, change SUIT to use the same behavior as squareone and only show the user's username. Do this by not setting the first or last name attributes in UserInfo, which should trigger the Firefly JavaScript layer to fall back to displaying only the username.
Member
Author
|
Alas, this doesn't seem to work the way that I thought it would from the JavaScript code. I thought this piece of code: would fall back to username, but alas it seems to produce an empty string. I'm not sure why given that first name and last name should both be empty strings. (I tested this by changing Gafaelfawr to not pass This may require someone with more knowledge of the Firefly code to take a quick glance and tell me what I'm missing. |
Contributor
|
We'll take a look at this, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing the user's name in an HTTP header, but HTTP headers
only truly support ASCII (and, if not ASCII, use ISO 8859-1). This
means we cannot represent many people's names.
Rather than use a more complicated encoding solution to pass the
name down, change SUIT to use the same behavior as squareone and only
show the user's username. Do this by not setting the first or last
name attributes in UserInfo, which should trigger the Firefly
JavaScript layer to fall back to displaying only the username.