Lupl/ttl rewrite #29
Merged
Lupl/ttl rewrite #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pl
force-pushed
the
lupl/ttl-rewrite
branch
2 times, most recently
from
959c9db to
af7bcc9
Compare
The change introduces an overhaul and partial rewrite of the lodkit.ttl constructor. 1. Discontinuation of skip functionality and graph parameter in the initializer The skip functionality is an awkward and ineffecient feature that isn't really needed, so it might as well be cut from the implementation. Also, passing a graph instance to the initializer introduces state and is not in line with the idea of the to_graph method as a mere convenience method that accepts a graph instance anyways. 2. Making lodkit.ttl an Iterable lodkit.ttl should be an Iterable, not an Iterator. Functionally, the constructor could also be expressed as a generator function (see the internal lodkit.ttl._generate_triples); using a class however allows to match/case against the lodkit.ttl type and express a union type of _TPredicateObjectPair *recursively*. Closes #26. Closes #27. Closes #28.
lu-pl
force-pushed
the
lupl/ttl-rewrite
branch
5 times, most recently
from
cd7fa81 to
a253cd9
Compare
The change introduces explicitely defind lodkit.ttl tests and gets rid of property-based test parameter constructors.
The change implements a recursive type for predicate-object pairs used in lodkit.ttl. Closes #31.
lu-pl
force-pushed
the
lupl/ttl-rewrite
branch
from
a253cd9 to
ede93c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.